Re: [PATCH v1 4/4] git gui: allow for a long recentrepo list

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Dec 14, 2015, 22:36 UTC
Message-ID: <CAPig+cSE41rHyq8hNcEL+qJaZrSwp0uc=Y6gPiRcj_T1EgQ4cg@mail.gmail.com>
In-Reply-To: <1450105743-2432-5-git-send-email-philipoakley@iee.org>

On Mon, Dec 14, 2015 at 10:09 AM, Philip Oakley <philipoakley@iee.org> wrote:

Show 6 quoted lines

> The gui.recentrepo list may be longer than the maxrecent setting.
> Allow extra space to show any extra entries.
>
> In an ideal world, the git gui would limit the number of entries
> to the maxrecent setting, however the recentrepo config list may
> have been extended outwith the gui, or the maxrecent setting changed

s/outwith/without/

Show 20 quoted lines

> to a reduced value. Further, when testing the gui's recentrepo
> logic it is useful to show these extra, but valid, entries.
>
> Signed-off-by: Philip Oakley <philipoakley@iee.org>
> ---
> diff --git a/git-gui/lib/choose_repository.tcl b/git-gui/lib/choose_repository.tcl
> index ad7a888..a08ed4f 100644
> --- a/git-gui/lib/choose_repository.tcl
> +++ b/git-gui/lib/choose_repository.tcl
> @@ -153,7 +153,7 @@ constructor pick {} {
>                         -background [get_bg_color $w_body.recentlabel] \
>                         -wrap none \
>                         -width 50 \
> -                       -height $maxrecent
> +                       -height [expr {$maxrecent + 5}]
>                 $w_recentlist tag conf link \
>                         -foreground blue \
>                         -underline 1
> --
> 2.5.2.windows.2