git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v1 0/4] Fix git-gui when recentrepo list has duplicates

From
Philip Oakley <philipoakley@iee.org>
Date
Dec 14, 2015, 15:08 UTC
Message-ID
<1450105743-2432-1-git-send-email-philipoakley@iee.org>
In-Reply-To
<3453668A49C94C2AA39911FC594AE151@PhilipOakley>

This is the patch series which follows from a user report of not being able to start the git-gui when it contained duplicate entries.

The git gui design assumes that there will never be duplicate entries in the recent repo list, and attempts to keep it that way.

For reasons unknown (other applications or tcl bugs?) there are cases where the global .gitconfig does contain duplicate entries in the gui.recentrepo config var. contrary to expectation.

The patch series fixes the root of the issue first, then patches the logic for the two functional usages of _unset_recentrepo.

Finally, the displayable recentrepos list region is expanded to allow extended recentrepo lists to at least be shown, before the git-gui wrangles then back down to the allowed maxrecent size.

Philip Oakley (4):
  git-gui: remove duplicate entries from .gitconfig's gui.recentrepo
  git gui: cope with duplicates in _get_recentrepo
  git gui: de-dup selected repo from recentrepo history
  git gui: allow for a long recentrepo list
 git-gui/lib/choose_repository.tcl | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)
-- 
2.5.2.windows.2
Previous: Philip OakleyNext: Philip Oakley
Message 2 of 11 in “git gui: fail on dual entries in recent repo list”
  1. Philip OakleyDec 13, 2015
  2. 0/4 Fix git-gui when recentrepo list has duplicatesPhilip Oakley, Dec 14, 2015
  3. 1/4 git-gui: remove duplicate entries from .gitconfig's gui.recentrepoPhilip Oakley, Dec 14, 2015
  4. Eric SunshineDec 14, 2015
  5. Philip OakleyDec 16, 2015
  6. Eric SunshineDec 17, 2015
  7. 2/4 git gui: cope with duplicates in _get_recentrepoPhilip Oakley, Dec 14, 2015
  8. 3/4 git gui: de-dup selected repo from recentrepo historyPhilip Oakley, Dec 14, 2015
  9. 4/4 git gui: allow for a long recentrepo listPhilip Oakley, Dec 14, 2015
  10. Eric SunshineDec 14, 2015
  11. Philip OakleyDec 14, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.