git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v1 4/4] git gui: allow for a long recentrepo list

From
Philip Oakley <philipoakley@iee.org>
Date
Dec 14, 2015, 15:09 UTC
Message-ID
<1450105743-2432-5-git-send-email-philipoakley@iee.org>
In-Reply-To
<1450105743-2432-1-git-send-email-philipoakley@iee.org>

The gui.recentrepo list may be longer than the maxrecent setting. Allow extra space to show any extra entries.

In an ideal world, the git gui would limit the number of entries to the maxrecent setting, however the recentrepo config list may have been extended outwith the gui, or the maxrecent setting changed to a reduced value. Further, when testing the gui's recentrepo logic it is useful to show these extra, but valid, entries.

Signed-off-by: Philip Oakley <philipoakley@iee.org>
---
 git-gui/lib/choose_repository.tcl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/git-gui/lib/choose_repository.tcl b/git-gui/lib/choose_repository.tcl
index ad7a888..a08ed4f 100644
--- a/git-gui/lib/choose_repository.tcl
+++ b/git-gui/lib/choose_repository.tcl
@@ -153,7 +153,7 @@ constructor pick {} {
 			-background [get_bg_color $w_body.recentlabel] \
 			-wrap none \
 			-width 50 \
-			-height $maxrecent
+			-height [expr {$maxrecent + 5}]
 		$w_recentlist tag conf link \
 			-foreground blue \
 			-underline 1
-- 
2.5.2.windows.2
Previous: Philip OakleyNext: Eric Sunshine
Message 9 of 11 in “git gui: fail on dual entries in recent repo list”
  1. Philip OakleyDec 13, 2015
  2. 0/4 Fix git-gui when recentrepo list has duplicatesPhilip Oakley, Dec 14, 2015
  3. 1/4 git-gui: remove duplicate entries from .gitconfig's gui.recentrepoPhilip Oakley, Dec 14, 2015
  4. Eric SunshineDec 14, 2015
  5. Philip OakleyDec 16, 2015
  6. Eric SunshineDec 17, 2015
  7. 2/4 git gui: cope with duplicates in _get_recentrepoPhilip Oakley, Dec 14, 2015
  8. 3/4 git gui: de-dup selected repo from recentrepo historyPhilip Oakley, Dec 14, 2015
  9. 4/4 git gui: allow for a long recentrepo listPhilip Oakley, Dec 14, 2015
  10. Eric SunshineDec 14, 2015
  11. Philip OakleyDec 14, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.