git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/6] path: Make the 'get_st_mode_bits' symbol a file static

From
Eric Sunshine <sunshine@sunshineco.com>
Date
Apr 28, 2013, 02:26 UTC
Message-ID
<CAPig+cS0dwm_aHCx6zUCCKnrWk1WXMaO54FOKtkwXXftDLr=og@mail.gmail.com>
In-Reply-To
<517C1BF9.2050604@ramsay1.demon.co.uk>

On Sat, Apr 27, 2013 at 2:42 PM, Ramsay Jones <ramsay@ramsay1.demon.co.uk> wrote:

>
> On MinGW, sparse issues an "'get_st_mode_bits' not declared. Should
> it be static?" warning. The MinGW and MSVC builds do not see the
> declaration of this function, within git-compat-util.h, due to it's
s/it's/its/
Show 8 quoted lines
> placement within an preprocessor conditional. (So, one solution would
> be to simply move the declaration to the top level of the header.)
>
> In order to suppress the warning, since this symbol does not need
> more than file visibility, we simply remove the declaration from
> the header and add the static modifier to the function definition.
>
> Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Previous: Ramsay JonesNext: Torsten Bögershausen
Message 2 of 8 in “path: Make the 'get_st_mode_bits' symbol a file static”
  1. 2/6 path: Make the 'get_st_mode_bits' symbol a file staticRamsay Jones, Apr 27, 2013
  2. Eric SunshineApr 28, 2013
  3. Torsten BögershausenApr 28, 2013
  4. Torsten BögershausenApr 28, 2013
  5. Ramsay JonesApr 29, 2013
  6. Junio C HamanoApr 28, 2013
  7. Ramsay JonesApr 29, 2013
  8. Junio C HamanoApr 30, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.