From: Eric Sunshine <sunshine@sunshineco.com>
Date: Sun, 28 Apr 2013 02:26:23 GMT
Subject: Re: [PATCH 2/6] path: Make the 'get_st_mode_bits' symbol a file static
Message-ID: <CAPig+cS0dwm_aHCx6zUCCKnrWk1WXMaO54FOKtkwXXftDLr=og@mail.gmail.com>
In-Reply-To: <517C1BF9.2050604@ramsay1.demon.co.uk>

On Sat, Apr 27, 2013 at 2:42 PM, Ramsay Jones
<ramsay@ramsay1.demon.co.uk> wrote:
>
> On MinGW, sparse issues an "'get_st_mode_bits' not declared. Should
> it be static?" warning. The MinGW and MSVC builds do not see the
> declaration of this function, within git-compat-util.h, due to it's

s/it's/its/

> placement within an preprocessor conditional. (So, one solution would
> be to simply move the declaration to the top level of the header.)
>
> In order to suppress the warning, since this symbol does not need
> more than file visibility, we simply remove the declaration from
> the header and add the static modifier to the function definition.
>
> Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>