git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/6] path: Make the 'get_st_mode_bits' symbol a file static

From
Junio C Hamano <gitster@pobox.com>
Date
Apr 30, 2013, 17:00 UTC
Message-ID
<7v1u9seyy5.fsf@alter.siamese.dyndns.org>
In-Reply-To
<517EF9D4.50105@ramsay1.demon.co.uk>
Ramsay Jones <ramsay@ramsay1.demon.co.uk> writes:
> However, I'm always a little wary when I hear someone say "this may be
> useful to others in the future, so lets do X to make it easier ...".
> I have noticed that, much more often than not, that future user never
> does materialise ... ;-)

I do not think you are reading the reason for the function correctly. It is not "We may find it useful elsewhere".

It is "We knew Windows benefits from having a 'quick, incorrect, but the incorrectness happens not matter to the caller' hack, and we used to use it everywhere. But we identified one location we need to disable the hack for correctness, hence this 'slow-but-correct' function. There may still be other places that needs fixing by calling it".

Previous: Ramsay Jones
Message 8 of 8 in “path: Make the 'get_st_mode_bits' symbol a file static”
  1. 2/6 path: Make the 'get_st_mode_bits' symbol a file staticRamsay Jones, Apr 27, 2013
  2. Eric SunshineApr 28, 2013
  3. Torsten BögershausenApr 28, 2013
  4. Torsten BögershausenApr 28, 2013
  5. Ramsay JonesApr 29, 2013
  6. Junio C HamanoApr 28, 2013
  7. Ramsay JonesApr 29, 2013
  8. Junio C HamanoApr 30, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.