Re: [PATCH 08/19] checkout: split part of it to new command switch
- From
Eric Sunshine <sunshine@sunshineco.com>
- Date
- Jan 31, 2019, 07:51 UTC
- Message-ID
- <CAPig+cRpxXA1uv_OqX9R9h6auBWE5=iS8CsxdB4qS6VaEqUadA@mail.gmail.com>
- In-Reply-To
- <CACsJy8C2fx-+NxS+ahmmHDgLrwtyiCV6WEEfpmYwfcPM3kYVvA@mail.gmail.com>
On Thu, Jan 31, 2019 at 2:44 AM Duy Nguyen <pclouds@gmail.com> wrote:
Show 12 quoted lines
> On Thu, Jan 31, 2019 at 1:25 PM Eric Sunshine <sunshine@sunshineco.com> wrote: > > I find, however, that the top-level git-switch "DESCRIPTION" section, > > which talks about "switching branches" doesn't actually ever explain > > what it means to "switch" to a branch. Even adding a simple sentence > > stating that "switching to a branch means that a newly-created commit > > will be a direct child of the current head of the branch, and that the > > branch will be updated to point at the new commit" would help cement > > the meaning of branch switching in the reader's mind (rather than > > assuming the reader understands that implicitly). > > Thanks. How about this? I skipped the "update branch to point to the > new commit" ...
I came to the same conclusion (about dropping this bit) upon re-reading what I wrote.
Show 5 quoted lines
> DESCRIPTION > ----------- > Switch to a specified branch. The working three and the index are also > updated to match the branch. All new commits will be added to the tip > of this branch.
Yes, this is good. Simple and direct. A couple minor fixes:
s/three/tree/ s/also//