Re: [PATCH v3 10/21] checkout: split part of it to new command 'switch'

From: Jacob Keller <jacob.keller@gmail.com>
Date: Mar 10, 2019, 22:57 UTC
Message-ID: <3A57DE38-A5A7-468B-9509-4244C285896A@gmail.com>
In-Reply-To: <20190308095752.8574-11-pclouds@gmail.com>

On March 8, 2019 1:57:41 AM PST, "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com> wrote:

Show 18 quoted lines

>"git checkout" doing too many things is a source of confusion for many
>users (and it even bites old timers sometimes). To remedy that, the
>command will be split into two new ones: switch and
>something-to-checkout-paths. The good old "git checkout" command is
>still here and will be until all (or most of users) are sick of it.
>
>See the new man page for the final design of switch. The actual
>implementation though is still pretty much the same as "git checkout"
>and not completely aligned with the man page. Following patches will
>adjust their behavior to match the man page.
>---
> .gitignore                        |   1 +
> Documentation/config/advice.txt   |  13 +-
> Documentation/config/branch.txt   |   4 +-
> Documentation/config/checkout.txt |   9 +-
> Documentation/config/diff.txt     |   3 +-
> Documentation/git-checkout.txt    |   4 +
> Documentation/git-switch.txt      | 259 ++++++

Show 6 quoted lines

>+<new-branch>::
>+	Name for the new branch.
>+
>+<start-point>::
>+	The name of a commit at which to switch to before creating a
>+	new branch or detach from.

The wording here (and a few other places) feels awkward to me. I don't really have a better wording but maybe:

--- The name of the commit to switch to when creating a new branch or detaching HEAD ---

The original has weird tense when using detach.

There were a few other places like this where the wording was "or detach from" but where the verb tense was confusing

Thanks, Jake

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.