Re: [PATCHv3 1/9] t7408: modernize style

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Aug 9, 2016, 06:59 UTC
Message-ID: <CAPig+cRnDVMBZzKOOS-fW+hNaCHhYRVLM+d_akZcB4H5iyqfKA@mail.gmail.com>
In-Reply-To: <20160809040811.21408-2-sbeller@google.com>

On Tue, Aug 9, 2016 at 12:08 AM, Stefan Beller <sbeller@google.com> wrote:

Show 10 quoted lines

> t7408: modernize style
>
> Signed-off-by: Stefan Beller <sbeller@google.com>
> ---
> diff --git a/t/t7408-submodule-reference.sh b/t/t7408-submodule-reference.sh
> @@ -8,74 +8,76 @@ test_description='test clone --reference'
> +test_expect_success 'that reference gets used with add' '
> +       (
> +               cd super/sub &&
> +               echo "0 objects, 0 kilobytes" > expected &&

Since you're modernizing the style, perhaps drop the space after '>' here and elsewhere.

> +               git count-objects > current &&
> +               diff expected current

Modern practice is to call this 'actual' rather than 'current', but perhaps that's outside the scope of this patch(?).

> +       )
> +'