Re: [PATCHv2 0/6] git clone: Marry --recursive and --reference
- From
Jacob Keller <jacob.keller@gmail.com>
- Date
- Aug 9, 2016, 05:23 UTC
- Message-ID
- <CA+P7+xpHBkAHU7bAGHN4Hy1SnNS16zAg8XnFjzPY1CBKZV1s1Q@mail.gmail.com>
- In-Reply-To
- <20160809040811.21408-1-sbeller@google.com>
On Mon, Aug 8, 2016 at 9:08 PM, Stefan Beller <sbeller@google.com> wrote:
Show 14 quoted lines
> > v3: > > Thanks to Junios critial questions regarding the design, I took a step back > to look at the bigger picture. > > --super-reference sounds confusing. (what is the super referring to?) > So drop that approach. > > Instead we'll compute where the reference might be in the superproject scope > and ask the submodule clone operation to consider an optional reference. > If the referenced alternate is not there, we'll just warn about it and > carry on. >
This makes a lot more sense to me, and being able to use "reference-if-able" for regular clones may be a useful addition as well.
I looked over the other patches and didn't see anything obviously wrong, but take that with a grain of salt as I didn't spend a lot of time at it.
Thanks, Jake