Re: [PATCH v8 10/11] sequencer.c: define describe_cleanup_mode

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Mar 18, 2019, 20:04 UTC
Message-ID: <CAPig+cRmz2C7mAzc7Z=ZStAxd3qDSmbC4sbwyLGKqvkf2yzVPA@mail.gmail.com>
In-Reply-To: <4edca9db0b2a32621a7622b5b709db23b2512d1e.1552817044.git.liu.denton@gmail.com>

On Sun, Mar 17, 2019 at 6:16 AM Denton Liu <liu.denton@gmail.com> wrote:

Show 8 quoted lines

> Define a function which allows us to get the string configuration value
> of a enum commit_msg_cleanup_mode. This is done by refactoring
> get_cleanup_mode such that it uses a lookup table to find the mappings
> between string and enum and then using the same LUT in reverse to define
> describe_cleanup_mode.
>
> Reviewed-by: Eric Sunshine <sunshine@sunshineco.com>
> Reviewed-by: Junio C Hamano <gitster@pobox.com>

These two Reviewed-by: lines should be dropped for a couple reasons.

First, neither Junio nor I reviewed _this_ version of the patch.

Second, a Reviewed-by: is given explicitly (not taken). When a reviewer has thoroughly read and understood a patch and considers it problem-free, he or she may say explicitly "Reviewed-by: <me>", stating satisfaction that the patch seems worthy of inclusion in the project. If he sees fit, Junio may then pick up that Reviewed-by: at the time he queues the patch in his tree.

> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
> Signed-off-by: Denton Liu <liu.denton@gmail.com>