Re: [PATCH 1/1] Exit on invalid diff status of diff_filepair

From: Eric Sunshine <sunshine@sunshineco.com>
Date: May 1, 2025, 06:16 UTC
Message-ID: <CAPig+cRehhM-z0md_iV-VYCk_Qwv0A4zS1TfPqPxsrLZ3eYxvA@mail.gmail.com>
In-Reply-To: <20250430185309.11197-1-jakeroggenbuck2@gmail.com>

On Wed, Apr 30, 2025 at 2:53 PM Jake Roggenbuck <jakeroggenbuck2@gmail.com> wrote:

Show 11 quoted lines

> Has anyone gotten a chance to take a look at this simple fix?
> When git is built of the main branch, it still segfaults when there is an invalid diff_filepair.
>
>     git (main) $ make
>     <make output omitted>
>     git (main) $ cd ~/Repos/ECS50-3/hw3-skeleton-broken/
>     hw3-skeleton-broken (main) $ ~/Build/git/git diff
>     Segmentation fault (core dumped)
>     hw3-skeleton-broken (main) $
>
> Let me know if you have any feedback or suggestions.

Do you have a reproduction recipe which demonstrates the problem which your patch fixes? Including the recipe in the patch's commit message would help reviewers better understand the circumstances under which the crash occurs since the descriptions provided by both the original problem report[1] and the submitted patch[2] seem rather nebulous[3].

More importantly, if you have a reproduction recipe, then it can be used as the basis for creating a test which should accompany the patch (and which should be added to one of the `t/t40xx-*.sh` files). We can help you convert the reproduction recipe into a test if desired.

FOOTNOTES

[1]: https://lore.kernel.org/git/CAEUC8gmgq_yViedLGHOeSyvR9rQK+O-8Fh9wzds=2+326ngUjw@mail.gmail.com/

[2]: https://lore.kernel.org/git/20250108060151.7218-2-jakeroggenbuck2@gmail.com/

[3]: It is not clear, for instance, what an "object file" is in the provided description. Are you referring to one of the files under `.git/objects/`?