[PATCH 0/1] Exit on invalid diff status of diff_filepair
- From
Jake Roggenbuck <jakeroggenbuck2@gmail.com>
- Date
- Jan 8, 2025, 06:01 UTC
- Message-ID
- <20250108060151.7218-1-jakeroggenbuck2@gmail.com>
- In-Reply-To
- <CAEUC8gmgq_yViedLGHOeSyvR9rQK+O-8Fh9wzds=2+326ngUjw@mail.gmail.com>
Hi all,
Git showed that object files were empty, so I manually removed them. After removing a few object files, I ran `git diff` and I got a segfault.
I have since narrowed down the source of the error to a usage of `diff_filepair`. I also noticed that the `status` field of `diff_filepair` does not get set and stays a zero value. My fix is to check for that invalid status character and exit gracefully with an error message.
I modeled the behavior of this patch after what `git log` does in the same situation. `git log` will exit with a message that reads `bad object HEAD`.
I initially found this segfault when using git while working on a school assignment. I am really interested in helping fix this segfault. I'd be happy to hear any feedback.
Thank you!
Jake Roggenbuck (1): Exit on invalid diff status of diff_filepair
diff.c | 4 ++++ 1 file changed, 4 insertions(+)
-- 2.47.0