git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/1] Exit on invalid diff status of diff_filepair

From
Jake Roggenbuck <jakeroggenbuck2@gmail.com>
Date
Apr 30, 2025, 18:50 UTC
Message-ID
<20250430185309.11197-1-jakeroggenbuck2@gmail.com>
In-Reply-To
<20250108060151.7218-2-jakeroggenbuck2@gmail.com>
Hi all,

Has anyone gotten a chance to take a look at this simple fix? When git is built of the main branch, it still segfaults when there is an invalid diff_filepair.

    git (main) $ make
    <make output omitted>
    git (main) $ cd ~/Repos/ECS50-3/hw3-skeleton-broken/
    hw3-skeleton-broken (main) $ ~/Build/git/git diff
    Segmentation fault (core dumped)
    hw3-skeleton-broken (main) $
Let me know if you have any feedback or suggestions.
Signed-off-by: Jake Roggenbuck <jakeroggenbuck2@gmail.com>
Previous: Jake RoggenbuckNext: Jake Roggenbuck
Message 4 of 7 in “bug: Segfault with git diff”
  1. jake roggenbuckMay 19, 2024
  2. 0/1 Exit on invalid diff status of diff_filepairJake Roggenbuck, Jan 8, 2025
  3. 1/1 Exit on invalid diff status of diff_filepairJake Roggenbuck, Jan 8, 2025
  4. Jake RoggenbuckApr 30, 2025
  5. Jake RoggenbuckApr 30, 2025
  6. Eric SunshineMay 1, 2025
  7. Junio C HamanoMay 1, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.