Re: [PATCH] path_treatment: also ignore $GIT_DIR if it's not .git

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Dec 2, 2013, 01:21 UTC
Message-ID: <CAPig+cRVYLsVrmFzfKHE8VdYo90enuOpsir2HT8YueQsWs58ng@mail.gmail.com>
In-Reply-To: <20131201190447.GA31367@kaarsemaker.net>

On Sun, Dec 1, 2013 at 2:04 PM, Dennis Kaarsemaker <dennis@kaarsemaker.net> wrote:

Show 13 quoted lines

> diff --git a/t/t7508-status.sh b/t/t7508-status.sh
> index c987b5e..2bd7ef1 100755
> --- a/t/t7508-status.sh
> +++ b/t/t7508-status.sh
> @@ -198,6 +198,13 @@ test_expect_success 'status -s' '
>
>  '
>
> +test_expect_success 'status -s with non-standard $GIT_DIR' '
> +       mv .git .foo &&
> +       GIT_DIR=.foo git status -s >output &&
> +       test_cmp expect output &&
> +       mv .foo .git

If test_cmp returns a failure status, the following 'mv' command will never be invoked, thus all subsequent tests in the script will fail since the .git directory will be missing. Instead, use test_when_finished to restore .git from .foo.

Show 7 quoted lines

> +'
> +
>  test_expect_success 'status with gitignore' '
>         {
>                 echo ".gitignore" &&
> --
> 1.8.5-386-gb78cb96