Re: [PATCH] path_treatment: also ignore $GIT_DIR if it's not .git

From: Karsten Blees <karsten.blees@gmail.com>
Date: Dec 3, 2013, 19:00 UTC
Message-ID: <529E2A33.7000804@gmail.com>
In-Reply-To: <xmqqtxepokej.fsf@gitster.dls.corp.google.com>

Am 03.12.2013 19:32, schrieb Junio C Hamano:

Show 16 quoted lines

> Karsten Blees <karsten.blees@gmail.com> writes:
> 
>> So I figure that GIT_DIR is not meant to _rename_ the ".git" dir,
>> but to point somewhere _outside_ the worktree (or somewhere within
>> the .git dir).
> 
> Correct.
> 
>> If we don't want to support this, though, I think it would be more
>> approrpiate to issue a warning if GIT_DIR points to a worktree
>> location.
> 
> But how do tell what is and isn't a "worktree location"?  Having the
> path in the index would be one, but you may find it out only after
> issuing "git checkout $antient_commit".
>

In setup_work_tree(), the result of remove_leading_path(git_dir, work_tree) must be absolute or start with ".." or ".git", otherwise warn?