Re: [PATCH] path_treatment: also ignore $GIT_DIR if it's not .git

From: Thomas Rast <tr@thomasrast.ch>
Date: Dec 1, 2013, 23:08 UTC
Message-ID: <877gbop3so.fsf@linux-1gf2.Speedport_W723_V_Typ_A_1_00_098>
In-Reply-To: <CACsJy8CxR+wj-P+fxF37DU=Tzk=su+V=UudbO7NkqTMS8qTn_w@mail.gmail.com>

Duy Nguyen <pclouds@gmail.com> writes:

> On Mon, Dec 2, 2013 at 2:04 AM, Dennis Kaarsemaker
> <dennis@kaarsemaker.net> wrote:
>> We always ignore anything named .git, but we should also ignore the git
>> directory if the user overrides it by setting $GIT_DIR

[...]

Show 5 quoted lines

>> +       if (simplify_away(path->buf, path->len, simplify) || is_git_directory(path->buf))
>>                 return path_none;
>
> this adds 2 access, 1 lstat, 1 open, 1 read, 1 close to _every_ path
> we check. Is it worth the cost?

Moreover it is a much more inclusive check than what the commit message claims: it will ignore anything that looks like a .git directory, regardless of the name. In particular GIT_DIR doesn't have anything to do with it.

-- 
Thomas Rast
tr@thomasrast.ch