git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: t3010 broken by 2eac2a4

From
Eric Sunshine <sunshine@sunshineco.com>
Date
Aug 23, 2013, 04:32 UTC
Message-ID
<CAPig+cR0Z0gghUH5C6+XCuGQ3gz5JoWrnObVbbA5_ahPmC8G2Q@mail.gmail.com>
In-Reply-To
<CAPig+cSqtMOYvxbvXstm9nqQD9sQ378NKCHSK7Ec6GrK5VJiGA@mail.gmail.com>
On Thu, Aug 22, 2013 at 7:15 PM, Eric Sunshine <sunshine@sunshineco.com> wrote:
Show 28 quoted lines
> On Thu, Aug 22, 2013 at 7:12 PM, Junio C Hamano <gitster@pobox.com> wrote:
>> Eric Sunshine <sunshine@sunshineco.com> writes:
>>
>>> Status update: For the 'pathx' directory created by the t3010 test,
>>> directory_exists_in_index() returns false on OSX, but true is returned
>>> on Linux.
>>
>> Because a regular pathx/ju is in the index at that point, the
>> correct answer directory_exists_in_index() should give for 'pathx'
>> is "index_directory", not "index_nonexistent", I think.
>
> directory_exists_in_index() and directory_exists_in_index_icase() are
> behaving differently. You can replicate the problem on Linux by
> enabling core.ignorecase in the test (sans gmail whitespace damage):
>
> -->8--
> diff --git a/t/t3010-ls-files-killed-modified.sh b/t/t3010-ls-files-killed-modif
> index 3120efd..8c76160 100755
> --- a/t/t3010-ls-files-killed-modified.sh
> +++ b/t/t3010-ls-files-killed-modified.sh
> @@ -89,7 +89,7 @@ test_expect_success 'git ls-files -k to show killed files.' '
>         : >path9 &&
>         touch path10 &&
>         >pathx/ju/nk &&
> -       git ls-files -k >.output
> +       git -c core.ignorecase=true ls-files -k >.output
>  '
> -->8--

I sent a patch [1] which resolves the problem, although the solution is not especially pretty (due to some ugliness in the existing implementation).

[1]: http://thread.gmane.org/gmane.comp.version-control.git/232796
Previous: Eric SunshineNext: Junio C Hamano
Message 13 of 17 in “t3010 broken by 2eac2a4”
  1. Brian GernhardtAug 21, 2013
  2. Junio C HamanoAug 21, 2013
  3. Eric SunshineAug 22, 2013
  4. Junio C HamanoAug 22, 2013
  5. Eric SunshineAug 22, 2013
  6. Junio C HamanoAug 22, 2013
  7. Eric SunshineAug 22, 2013
  8. Junio C HamanoAug 22, 2013
  9. Eric SunshineAug 22, 2013
  10. Eric SunshineAug 22, 2013
  11. Junio C HamanoAug 22, 2013
  12. Eric SunshineAug 22, 2013
  13. Eric SunshineAug 23, 2013
  14. Junio C HamanoAug 23, 2013
  15. Eric SunshineAug 23, 2013
  16. Junio C HamanoAug 23, 2013
  17. Jeff KingAug 23, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.