git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: t3010 broken by 2eac2a4

From
Jeff King <peff@peff.net>
Date
Aug 23, 2013, 18:51 UTC
Message-ID
<20130823185158.GC30130@sigill.intra.peff.net>
In-Reply-To
<xmqqk3jcpbuc.fsf@gitster.dls.corp.google.com>
On Fri, Aug 23, 2013 at 10:15:55AM -0700, Junio C Hamano wrote:
Show 19 quoted lines
> When 5102c617 (Add case insensitivity support for directories when
> using git status, 2010-10-03) added the directories to the name-hash
> with trailing slash, there was only a single name hash table to
> which both real cache entries and leading directory prefixes are
> registered, so it made some sense to register them with trailing
> slashes so that we can tell what kind of entry is being returned.
> 
> But since 2092678c (name-hash.c: fix endless loop with
> core.ignorecase=true, 2013-02-28), these directory entries that are
> not the cache entries are kept track of in a separate hashtable,
> which makes me wonder if it still makes sense to register
> directories with trailing slashes.
> 
> And if we stop doing that (and instead if we shrunk the namelen when
> an unconverted caller asks for a name with a trailing slash to see
> if a directory exists in the index), wouldn't it automatically fix
> the directory_exists_in_index_icase()?  It does not need to assume
> that dirname[len] has '/'; after all, it may not even be a valid
> memory location in the first place.

Yeah, I think that is sane overall direction. When I did the sketch that eventually turned into Karsten's 2092678c, that was one of the goals. But I did not keep up with his response and the final patch, and I'm not sure if the slashes still serve some function. So it would definitely need somebody looking carefully at the current logic.

More details are in this sub-thread:
  http://thread.gmane.org/gmane.comp.version-control.git/215820/focus=216284
-Peff
Previous: Junio C Hamano
Message 17 of 17 in “t3010 broken by 2eac2a4”
  1. Brian GernhardtAug 21, 2013
  2. Junio C HamanoAug 21, 2013
  3. Eric SunshineAug 22, 2013
  4. Junio C HamanoAug 22, 2013
  5. Eric SunshineAug 22, 2013
  6. Junio C HamanoAug 22, 2013
  7. Eric SunshineAug 22, 2013
  8. Junio C HamanoAug 22, 2013
  9. Eric SunshineAug 22, 2013
  10. Eric SunshineAug 22, 2013
  11. Junio C HamanoAug 22, 2013
  12. Eric SunshineAug 22, 2013
  13. Eric SunshineAug 23, 2013
  14. Junio C HamanoAug 23, 2013
  15. Eric SunshineAug 23, 2013
  16. Junio C HamanoAug 23, 2013
  17. Jeff KingAug 23, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.