git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: t3010 broken by 2eac2a4

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 23, 2013, 05:36 UTC
Message-ID
<7vsiy1j7dd.fsf@alter.siamese.dyndns.org>
In-Reply-To
<CAPig+cR0Z0gghUH5C6+XCuGQ3gz5JoWrnObVbbA5_ahPmC8G2Q@mail.gmail.com>
Eric Sunshine <sunshine@sunshineco.com> writes:
> I sent a patch [1] which resolves the problem, although the solution
> is not especially pretty (due to some ugliness in the existing
> implementation).
Yeah, thanks.

I tend to agree with you that fixing the "icase" callee not to rely on having the trailing slash (which is looking past the end of the given string), instead of working that breakage around on the caller's side like your patch did, would be a better alternative, though.

Previous: Eric SunshineNext: Eric Sunshine
Message 14 of 17 in “t3010 broken by 2eac2a4”
  1. Brian GernhardtAug 21, 2013
  2. Junio C HamanoAug 21, 2013
  3. Eric SunshineAug 22, 2013
  4. Junio C HamanoAug 22, 2013
  5. Eric SunshineAug 22, 2013
  6. Junio C HamanoAug 22, 2013
  7. Eric SunshineAug 22, 2013
  8. Junio C HamanoAug 22, 2013
  9. Eric SunshineAug 22, 2013
  10. Eric SunshineAug 22, 2013
  11. Junio C HamanoAug 22, 2013
  12. Eric SunshineAug 22, 2013
  13. Eric SunshineAug 23, 2013
  14. Junio C HamanoAug 23, 2013
  15. Eric SunshineAug 23, 2013
  16. Junio C HamanoAug 23, 2013
  17. Jeff KingAug 23, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.