git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCHv4 9/9] t3301: Modernize

From
Eric Sunshine <sunshine@sunshineco.com>
Date
Nov 11, 2014, 01:07 UTC
Message-ID
<CAPig+cQuZ7F5OEVDJ8M-p8B5YB9YNgnNzbbNXS2Dzy6u5_rxdw@mail.gmail.com>
In-Reply-To
<CALKQrgec-_9kbqba7PBFvNpCpeRAb=Pq6-OMnrJ2nw0fh_5LjQ@mail.gmail.com>
On Mon, Nov 10, 2014 at 8:04 PM, Johan Herland <johan@herland.net> wrote:
Show 17 quoted lines
> On Mon, Nov 10, 2014 at 9:42 PM, Junio C Hamano <gitster@pobox.com> wrote:
>> Johan Herland <johan@herland.net> writes:
>>
>>> Make this test script appear somewhat less old-fashioned:
>>>  - Use test helper functions:
>>>     - write_script
>>>     - test_commit
>>>     - test_write_lines
>>>     - test_config
>>>     - test_unconfig
>>>     - test_path_is_missing
>>>  - Remove whitespace between redirection operators and their targets.
>>>  - Move preparation of "except" files into tests.
>>
>> expect, I think (no need to resend; I've fixed it up locally).
>
> Thanks.

One further modernization would be to use the name "actual" rather than "output" for files holding actual contents (as opposed to the "expect" contents).

Previous: Johan HerlandNext: Johan Herland
Message 16 of 17 in “[PATCHv4 0/9] Handling empty notes”
  1. Johan HerlandNov 9, 2014
  2. 1/9 builtin/notes: Fix premature failure when trying to add the empty blobJohan Herland, Nov 9, 2014
  3. 2/9 t3301: Verify that 'git notes' removes empty notes by defaultJohan Herland, Nov 9, 2014
  4. 3/9 builtin/notes: Improve namingJohan Herland, Nov 9, 2014
  5. 4/9 builtin/notes: Refactor note file path into struct note_dataJohan Herland, Nov 9, 2014
  6. 5/9 builtin/notes: Simplify early exit code in add()Johan Herland, Nov 9, 2014
  7. Junio C HamanoNov 10, 2014
  8. Johan HerlandNov 11, 2014
  9. Junio C HamanoNov 11, 2014
  10. 6/9 builtin/notes: Split create_note() to clarify add vs. remove logicJohan Herland, Nov 9, 2014
  11. 7/9 builtin/notes: Add --allow-empty, to allow storing empty notesJohan Herland, Nov 9, 2014
  12. 8/9 notes: Empty notes should be shown by 'git log'Johan Herland, Nov 9, 2014
  13. 9/9 t3301: ModernizeJohan Herland, Nov 9, 2014
  14. Junio C HamanoNov 10, 2014
  15. Johan HerlandNov 11, 2014
  16. Eric SunshineNov 11, 2014
  17. Johan HerlandNov 11, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.