Re: [PATCHv4 9/9] t3301: Modernize

From: Johan Herland <johan@herland.net>
Date: Nov 11, 2014, 01:50 UTC
Message-ID: <CALKQrgfHNj=TRnFL+5P-_8YCs4D6SF6S9xBqeVAdvj0c+USp4Q@mail.gmail.com>
In-Reply-To: <CAPig+cQuZ7F5OEVDJ8M-p8B5YB9YNgnNzbbNXS2Dzy6u5_rxdw@mail.gmail.com>

On Tue, Nov 11, 2014 at 2:07 AM, Eric Sunshine <sunshine@sunshineco.com> wrote:

Show 22 quoted lines

> On Mon, Nov 10, 2014 at 8:04 PM, Johan Herland <johan@herland.net> wrote:
>> On Mon, Nov 10, 2014 at 9:42 PM, Junio C Hamano <gitster@pobox.com> wrote:
>>> Johan Herland <johan@herland.net> writes:
>>>
>>>> Make this test script appear somewhat less old-fashioned:
>>>>  - Use test helper functions:
>>>>     - write_script
>>>>     - test_commit
>>>>     - test_write_lines
>>>>     - test_config
>>>>     - test_unconfig
>>>>     - test_path_is_missing
>>>>  - Remove whitespace between redirection operators and their targets.
>>>>  - Move preparation of "except" files into tests.
>>>
>>> expect, I think (no need to resend; I've fixed it up locally).
>>
>> Thanks.
>
> One further modernization would be to use the name "actual" rather
> than "output" for files holding actual contents (as opposed to the
> "expect" contents).

Agreed. Will be fixed in the re-roll.

...Johan

-- 
Johan Herland, <johan@herland.net>
www.herland.net