From: Eric Sunshine <sunshine@sunshineco.com>
Date: Tue, 11 Nov 2014 01:07:32 GMT
Subject: Re: [PATCHv4 9/9] t3301: Modernize
Message-ID: <CAPig+cQuZ7F5OEVDJ8M-p8B5YB9YNgnNzbbNXS2Dzy6u5_rxdw@mail.gmail.com>
In-Reply-To: <CALKQrgec-_9kbqba7PBFvNpCpeRAb=Pq6-OMnrJ2nw0fh_5LjQ@mail.gmail.com>

On Mon, Nov 10, 2014 at 8:04 PM, Johan Herland <johan@herland.net> wrote:
> On Mon, Nov 10, 2014 at 9:42 PM, Junio C Hamano <gitster@pobox.com> wrote:
>> Johan Herland <johan@herland.net> writes:
>>
>>> Make this test script appear somewhat less old-fashioned:
>>>  - Use test helper functions:
>>>     - write_script
>>>     - test_commit
>>>     - test_write_lines
>>>     - test_config
>>>     - test_unconfig
>>>     - test_path_is_missing
>>>  - Remove whitespace between redirection operators and their targets.
>>>  - Move preparation of "except" files into tests.
>>
>> expect, I think (no need to resend; I've fixed it up locally).
>
> Thanks.

One further modernization would be to use the name "actual" rather
than "output" for files holding actual contents (as opposed to the
"expect" contents).