Re: [PATCH v2] [Outreachy][Patch v1] t3404: avoid losing exit status to pipes

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Oct 6, 2024, 10:21 UTC
Message-ID: <CAPig+cQfoMe2H=1QwnSmGNxcEG0abjfLQAC1W7tYaQiMjYvuOg@mail.gmail.com>
In-Reply-To: <CAPSxiM-=wtsd_XH3FY+C+1V_MwNkiMtRDwOKQH4r+6Cfj5Vydw@mail.gmail.com>

On Sun, Oct 6, 2024 at 5:32 AM Usman Akinyemi <usmanakinyemi202@gmail.com> wrote:

Show 9 quoted lines

> On Sun, Oct 6, 2024 at 9:19 AM Eric Sunshine <sunshine@sunshineco.com> wrote:
> > So, I think it makes sense to stop here and consider this microproject
> > successful (unless some other reviewer notices some problem or
> > requests some other change).
>
> Thanks Eric Sunshine, I appreciate your time and review. I am more
> eager to continue working on it after review from the others. And also
> would like to work on the test_line_count also if permitted. Thank you
> very much.

You don't have to ask permission; if you feel like converting the test to use test_line_count(), you are welcome to do so.