Re: [PATCH bc/connect-plink] t5601-clone: remove broken and pointless check for plink.exe
- From
Eric Sunshine <sunshine@sunshineco.com>
- Date
- Aug 11, 2015, 23:26 UTC
- Message-ID
- <CAPig+cQd-ocaKV3V+Ky34i_Fw5RDo-HZ0Qm3=2km7o0YRja3BA@mail.gmail.com>
- In-Reply-To
- <xmqq37zpo2nr.fsf@gitster.dls.corp.google.com>
On Tue, Aug 11, 2015 at 6:56 PM, Junio C Hamano <gitster@pobox.com> wrote:
Show 24 quoted lines
> Eric Sunshine <sunshine@sunshineco.com> writes: > >> On Tue, Aug 11, 2015 at 4:51 PM, Johannes Sixt <j6t@kdbg.org> wrote: >>> Invoking plink requires special treatment, and we have support and even >>> test cases for the commands 'plink' and 'tortoiseplink'. We also support >>> .exe variants for these two and there is a test for 'plink.exe'. >>> >>> On Windows, however, where support for plink.exe would be relevant, the >>> test case fails because it is not possible to execute a file with a .exe >>> extension that is actually not a binary executable---it is a shell >>> script in our test. We have to disable the test case on Windows. >>> >>> Considering, that 'plink.exe' is irrelevant on non-Windows, let's just >>> remove the test and assume that the code "just works". >> >> putty and plink are used on Unix as well. A quick check of Mac OS X, >> Linux, and FreeBSD reveals that package managers on each platform have >> putty and plink packages available. > > But they do not force their users to say "plink.exe", but instead > let them invoke "plink", no? > > The test before the one that was removed is about "plink" (sans .exe), > and what was removed is with ".exe", so I think J6t's patch is OK.
Ah, you're correct. I overlooked the extra emphasis j6t's commit message placed on ".exe".
-- -- *** Please reply-to-all at all times *** *** (do not pretend to know who is subscribed and who is not) *** *** Please avoid top-posting. *** The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free. You received this message because you are subscribed to the Google Groups "msysGit" group. To post to this group, send email to msysgit@googlegroups.com To unsubscribe from this group, send email to msysgit+unsubscribe@googlegroups.com For more options, and view previous threads, visit this group at http://groups.google.com/group/msysgit?hl=en_US?hl=en --- You received this message because you are subscribed to the Google Groups "Git for Windows" group. To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout.