git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH bc/connect-plink] t5601-clone: remove broken and pointless check for plink.exe

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Aug 12, 2015, 11:07 UTC
Message-ID
<866a41f50ef9b4807da72576a4bca717@www.dscho.org>
In-Reply-To
<55CA6066.5070500@kdbg.org>
Hi Johannes,
On 2015-08-11 22:51, Johannes Sixt wrote:
Show 8 quoted lines
> Invoking plink requires special treatment, and we have support and even
> test cases for the commands 'plink' and 'tortoiseplink'. We also support
> .exe variants for these two and there is a test for 'plink.exe'.
> 
> On Windows, however, where support for plink.exe would be relevant, the
> test case fails because it is not possible to execute a file with a .exe
> extension that is actually not a binary executable---it is a shell
> script in our test. We have to disable the test case on Windows.
Oh how would I wish you were working on Git for Windows even *just* a bit *with* me. At least I would wish for a more specific description of the development environment, because it sure as hell is not anything anybody can download and install as easily as Git for Windows' SDK.
FWIW Git for Windows has this patch (that I wanted to contribute in due time, what with being busy with all those tickets) to solve the problem mentioned in your patch in a different way:
https://github.com/git-for-windows/git/commit/2fff4b54a0d4e5c5e2e4638c9b0739d3c1ff1e45
Please read this as my vote not to remove the test cases.

Thanks, Johannes

Previous: Eric SunshineNext: Erik Faye-Lund
Message 6 of 12 in “t5601-clone: remove broken and pointless check for plink.exe”
  1. t5601-clone: remove broken and pointless check for plink.exeJohannes Sixt, Aug 11, 2015
  2. Eric SunshineAug 11, 2015
  3. Junio C HamanoAug 11, 2015
  4. Junio C HamanoAug 11, 2015
  5. Eric SunshineAug 11, 2015
  6. Johannes SchindelinAug 12, 2015
  7. Erik Faye-LundAug 12, 2015
  8. Johannes SixtAug 12, 2015
  9. Johannes SchindelinAug 13, 2015
  10. Johannes SixtAug 13, 2015
  11. Johannes SchindelinAug 13, 2015
  12. Erik Faye-LundAug 13, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.