git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [msysGit] Re: [PATCH bc/connect-plink] t5601-clone: remove broken and pointless check for plink.exe

From
Johannes Sixt <j6t@kdbg.org>
Date
Aug 12, 2015, 18:31 UTC
Message-ID
<55CB9110.4060005@kdbg.org>
In-Reply-To
<CABPQNSZHtAKbe6JwxRoK3LpCabfp6r2_kTmF1qokObt_yKnSDg@mail.gmail.com>
Am 12.08.2015 um 13:58 schrieb Erik Faye-Lund:
Show 15 quoted lines
> On Wed, Aug 12, 2015 at 1:07 PM, Johannes Schindelin
> <johannes.schindelin@gmx.de> wrote:
>> FWIW Git for Windows has this patch (that I wanted to contribute
>> in  due time, what with being busy with all those tickets) to solve the
>> problem mentioned in your patch in a different way:
>>
>> https://github.com/git-for-windows/git/commit/2fff4b54a0d4e5c5e2e4638c9b0739d3c1ff1e45
>
> Yuck. On Windows, it's the extension of a file that dictates what kind
> of file it is (and if it's executable or not), not the contents. If we
> get a shell script written with the ".exe"-prefix, it's considered as
> an invalid executable by the system. We should consider it the same
> way, otherwise we're on the path to user-experience schizophrenia.
>
> I'm not sure I consider this commit a step in the right direction.

I, too, think that it is a wrong decision to pessimize git for the sake of a single test case.

-- Hannes
Previous: Erik Faye-LundNext: Johannes Schindelin
Message 8 of 12 in “t5601-clone: remove broken and pointless check for plink.exe”
  1. t5601-clone: remove broken and pointless check for plink.exeJohannes Sixt, Aug 11, 2015
  2. Eric SunshineAug 11, 2015
  3. Junio C HamanoAug 11, 2015
  4. Junio C HamanoAug 11, 2015
  5. Eric SunshineAug 11, 2015
  6. Johannes SchindelinAug 12, 2015
  7. Erik Faye-LundAug 12, 2015
  8. Johannes SixtAug 12, 2015
  9. Johannes SchindelinAug 13, 2015
  10. Johannes SixtAug 13, 2015
  11. Johannes SchindelinAug 13, 2015
  12. Erik Faye-LundAug 13, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.