Re: [PATCH v2 3/5] t1500: avoid changing working directory outside of tests

From: Eric Sunshine <sunshine@sunshineco.com>
Date: May 17, 2016, 22:48 UTC
Message-ID: <CAPig+cQ19DXqZx_D29qeQNz5pTVe-OGWFJG_2xWRX0XWCLk_ZQ@mail.gmail.com>
In-Reply-To: <20160517215214.GA16905@sigill.intra.peff.net>

On Tue, May 17, 2016 at 5:52 PM, Jeff King <peff@peff.net> wrote:

Show 15 quoted lines

> On Tue, May 17, 2016 at 04:48:33PM -0400, Eric Sunshine wrote:
>> On Tue, May 17, 2016 at 4:37 PM, Junio C Hamano <gitster@pobox.com> wrote:
>> > Eric Sunshine <sunshine@sunshineco.com> writes:
>> >> +                     git ${dir:+-C "$dir"} rev-parse --$o >actual &&
>> >
>> > This is kosher POSIX, but I vaguely recall some shells had trouble
>> > with the SP between -C and "$dir" in the past.  Let's see if anybody
>> > screams; hopefully I am misremembering or buggy shells died out.
>>
>> I also am bothered by a vague recollection of some issue (possibly
>> involving the internal space and lack of quotes around the entire
>> ${...}), but couldn't remember nor find a reference to the specific
>> details. Perhaps someone reading the patch has a better memory than I.
>
>   http://thread.gmane.org/gmane.comp.version-control.git/265094

Thanks for the link. I just tested with FreeBSD 8, and the shell indeed exhibits that broken behavior. The workaround in Kyle's patch isn't the prettiest (and is a bit verbose), but it gets the job done.

I can send v3 using that workaround unless Junio wants to patch it locally(?).