From: Eric Sunshine Date: Tue, 17 May 2016 22:48:16 GMT Subject: Re: [PATCH v2 3/5] t1500: avoid changing working directory outside of tests Message-ID: In-Reply-To: <20160517215214.GA16905@sigill.intra.peff.net> On Tue, May 17, 2016 at 5:52 PM, Jeff King wrote: > On Tue, May 17, 2016 at 04:48:33PM -0400, Eric Sunshine wrote: >> On Tue, May 17, 2016 at 4:37 PM, Junio C Hamano wrote: >> > Eric Sunshine writes: >> >> + git ${dir:+-C "$dir"} rev-parse --$o >actual && >> > >> > This is kosher POSIX, but I vaguely recall some shells had trouble >> > with the SP between -C and "$dir" in the past. Let's see if anybody >> > screams; hopefully I am misremembering or buggy shells died out. >> >> I also am bothered by a vague recollection of some issue (possibly >> involving the internal space and lack of quotes around the entire >> ${...}), but couldn't remember nor find a reference to the specific >> details. Perhaps someone reading the patch has a better memory than I. > > http://thread.gmane.org/gmane.comp.version-control.git/265094 Thanks for the link. I just tested with FreeBSD 8, and the shell indeed exhibits that broken behavior. The workaround in Kyle's patch isn't the prettiest (and is a bit verbose), but it gets the job done. I can send v3 using that workaround unless Junio wants to patch it locally(?).