git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 3/5] t1500: avoid changing working directory outside of tests

From
Eric Sunshine <sunshine@sunshineco.com>
Date
May 17, 2016, 20:48 UTC
Message-ID
<CAPig+cTAgB6DXoEeJaDVy7_J7QiqNOm6AJqZTiSowO6_jqa8_w@mail.gmail.com>
In-Reply-To
<xmqqeg90v2ss.fsf@gitster.mtv.corp.google.com>
On Tue, May 17, 2016 at 4:37 PM, Junio C Hamano <gitster@pobox.com> wrote:
Show 6 quoted lines
> Eric Sunshine <sunshine@sunshineco.com> writes:
>> +                     git ${dir:+-C "$dir"} rev-parse --$o >actual &&
>
> This is kosher POSIX, but I vaguely recall some shells had trouble
> with the SP between -C and "$dir" in the past.  Let's see if anybody
> screams; hopefully I am misremembering or buggy shells died out.

I also am bothered by a vague recollection of some issue (possibly involving the internal space and lack of quotes around the entire ${...}), but couldn't remember nor find a reference to the specific details. Perhaps someone reading the patch has a better memory than I.

Previous: Junio C HamanoNext: Jeff King
Message 9 of 16 in “modernize t1500”
  1. 0/5 modernize t1500Eric Sunshine, May 17, 2016
  2. 1/5 t1500: be considerate to future potential testsEric Sunshine, May 17, 2016
  3. 2/5 t1500: test_rev_parse: facilitate future test enhancementsEric Sunshine, May 17, 2016
  4. SZEDER GáborMay 18, 2016
  5. Eric SunshineMay 18, 2016
  6. Eric SunshineMay 18, 2016
  7. 3/5 t1500: avoid changing working directory outside of testsEric Sunshine, May 17, 2016
  8. Junio C HamanoMay 17, 2016
  9. Eric SunshineMay 17, 2016
  10. Jeff KingMay 17, 2016
  11. Eric SunshineMay 17, 2016
  12. Junio C HamanoMay 17, 2016
  13. SZEDER GáborMay 17, 2016
  14. Eric SunshineMay 18, 2016
  15. 4/5 t1500: avoid setting configuration options outside of testsEric Sunshine, May 17, 2016
  16. 5/5 t1500: avoid setting environment variables outside of testsEric Sunshine, May 17, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.