Re: [PATCH v10.1 7/7] bisect: allow any terms set by user

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 27, 2015, 04:25 UTC
Message-ID: <CAPc5daXSnovQPxR5kVoeRy4kApH7DiuTDvAz1ooQFp=5DZZg4Q@mail.gmail.com>
In-Reply-To: <CAP8UFD1PyS_qM3EHW_Nzmo=3aeTDkZ0M3hnhRQANAO+ShF3H1Q@mail.gmail.com>

On Fri, Jun 26, 2015 at 9:10 PM, Christian Couder <christian.couder@gmail.com> wrote:

Show 8 quoted lines

>
> If we don't want to support positional arguments, then I would suggest
> supporting first the following instead:
>
>          git bisect terms --name-good=fast --name-bad=slow
>          git bisect terms --name-bad=slow --name-good=fast
>
> This would make the interface consistent with the code.

Which somewhat defeats the point of introducing "old" and "new", though. The "terms" support is for people who feel that good/bad would be too confusing for the particular bisect session (e.g. because they are hunting for a fix).

Show 7 quoted lines

>> We may want to start supporting
>>
>>         git bisect start --new=master --old=maint
>
> Maybe we could also support:
>
> git bisect start --name-good=fast --name-bad=slow --fast=maint --slow=master

The same comment for the token after --name-, but allowing the terms to be set at "start" could be a type-saver. With need for added "--name-" prefix (worse, twice), I am not sure if it would be seen as a useful type-saver, though.

Thanks.