git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] git: make "git -C '' <cmd>" not to barf

From
Junio C Hamano <gitster@pobox.com>
Date
Mar 3, 2015, 18:00 UTC
Message-ID
<CAPc5daWFAV2P_MCCo=oz2Be=2_L5NVxNweY+rUbU5OcK84wVaQ@mail.gmail.com>
In-Reply-To
<vpq385mgifi.fsf@anie.imag.fr>

On Tue, Mar 3, 2015 at 8:22 AM, Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> wrote:

Show 5 quoted lines
> Karthik Nayak <karthik.188@gmail.com> writes:
>
>> now it works like cd "" which silently succeeds
>
> Missing "." at end of sentence.
And lack of capitalization at the beginning.

More importantly, lack of justification--why is it a good idea to make "it works like cd ''" in the first place?

>
>>  git.c | 4 +++-
>
> That would probably also deserve a test.

Another "huh?" I had on the actual code was if this counts as "envchanged", if you are not actually changing the directory at all.

Is this meant as a "micro" for GSoC, by the way?
Previous: Matthieu MoyNext: Karthik Nayak
Message 3 of 4 in “git: make "git -C '' <cmd>" not to barf”
  1. git: make "git -C '' <cmd>" not to barfKarthik Nayak, Mar 3, 2015
  2. Matthieu MoyMar 3, 2015
  3. Junio C HamanoMar 3, 2015
  4. Karthik NayakMar 4, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.