From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 03 Mar 2015 18:00:13 GMT
Subject: Re: [PATCH] git: make "git -C '' <cmd>" not to barf
Message-ID: <CAPc5daWFAV2P_MCCo=oz2Be=2_L5NVxNweY+rUbU5OcK84wVaQ@mail.gmail.com>
In-Reply-To: <vpq385mgifi.fsf@anie.imag.fr>

On Tue, Mar 3, 2015 at 8:22 AM, Matthieu Moy
<Matthieu.Moy@grenoble-inp.fr> wrote:
> Karthik Nayak <karthik.188@gmail.com> writes:
>
>> now it works like cd "" which silently succeeds
>
> Missing "." at end of sentence.

And lack of capitalization at the beginning.

More importantly, lack of justification--why is it a good idea to make
"it works like cd ''" in the first place?

>
>>  git.c | 4 +++-
>
> That would probably also deserve a test.

Another "huh?" I had on the actual code was if this counts as "envchanged", if
you are not actually changing the directory at all.

Is this meant as a "micro" for GSoC, by the way?