Re: [PATCH] git: make "git -C '' <cmd>" not to barf

From: Karthik Nayak <karthik.188@gmail.com>
Date: Mar 4, 2015, 08:41 UTC
Message-ID: <E3F15B02-CDDA-473C-86D0-2A337FBDF185@gmail.com>
In-Reply-To: <CAPc5daWFAV2P_MCCo=oz2Be=2_L5NVxNweY+rUbU5OcK84wVaQ@mail.gmail.com>

On March 3, 2015 11:30:13 PM GMT+05:30, Junio C Hamano <gitster@pobox.com> wrote:

Show 9 quoted lines

>On Tue, Mar 3, 2015 at 8:22 AM, Matthieu Moy
><Matthieu.Moy@grenoble-inp.fr> wrote:
>> Karthik Nayak <karthik.188@gmail.com> writes:
>>
>>> now it works like cd "" which silently succeeds
>>
>> Missing "." at end of sentence.
>
>And lack of capitalization at the beginning.

Yes, noted, Will fix with next patch.

Show 8 quoted lines

>
>More importantly, lack of justification--why is it a good idea to make
>"it works like cd ''" in the first place?
>
>>
>>>  git.c | 4 +++-
>>
>> That would probably also deserve a test.

Will include a patch with next patch version.

Show 6 quoted lines

>
>Another "huh?" I had on the actual code was if this counts as
>"envchanged", if
>you are not actually changing the directory at all.
>
>Is this meant as a "micro" for GSoC, by the way?

Yes, it's meant for GSoC. I did overlook that. Will fix in next patch version. Thanks for your suggestions