git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/2] a few more redundant system include cleanups

From
Carlo Arenas <carenas@gmail.com>
Date
Jun 19, 2019, 09:12 UTC
Message-ID
<CAPUEspgRnGd4nT3yd2YTGMt8t4qQ=V3GGNeTih3cmjnZHNextw@mail.gmail.com>
In-Reply-To
<20190618155326.GA4014@sigill.intra.peff.net>
On Tue, Jun 18, 2019 at 8:53 AM Jeff King <peff@peff.net> wrote:
>
> Thanks, this looks good to me. I fixed the system headers in xinclude.h,
> but didn't think to check for individual C files including them.

also noticed that after the refactoring some files will include a couple of headers twice (not an issue, though thanks to the header guards) but didn't send that patch to reduce the churn and avoid confusion.

> I did a quick grep for similar cases, and didn't find any that I think
> would be problematic. There were a few cleanups, below.

would you mind if I add your 2 patches to a series and include that missing one?, that way I'll also have a chance to write a better commit message from my original change, including the other feedback I got as well

Carlo

PS. is there a recommendation on how to version a patch that move into a series that would be preferred?

Previous: Jeff KingNext: Jeff King
Message 6 of 17 in “xdiff: avoid accidental redefinition of LFS feature in OpenIndiana”
  1. xdiff: avoid accidental redefinition of LFS feature in OpenIndianaCarlo Marcelo Arenas Belón, Jun 18, 2019
  2. Johannes SchindelinJun 18, 2019
  3. 0/2 a few more redundant system include cleanupsJeff King, Jun 18, 2019
  4. 1/2 verify-tag: drop signal.h includeJeff King, Jun 18, 2019
  5. 2/2 wt-status.h: drop stdio.h includeJeff King, Jun 18, 2019
  6. Carlo ArenasJun 19, 2019
  7. Jeff KingJun 19, 2019
  8. Junio C HamanoJul 3, 2019
  9. Carlo ArenasJul 4, 2019
  10. 0/5 system header cleanupCarlo Marcelo Arenas Belón, Jul 28, 2019
  11. 1/5 verify-tag: drop signal.h includeCarlo Marcelo Arenas Belón, Jul 28, 2019
  12. 2/5 wt-status.h: drop stdio.h includeCarlo Marcelo Arenas Belón, Jul 28, 2019
  13. 3/5 xdiff: drop system includes in xutils.cCarlo Marcelo Arenas Belón, Jul 28, 2019
  14. 5/5 xdiff: remove duplicate headers from xpatience.cCarlo Marcelo Arenas Belón, Jul 28, 2019
  15. 4/5 xdiff: remove duplicate headers from xhistogram.cCarlo Marcelo Arenas Belón, Jul 28, 2019
  16. Jeff KingJul 28, 2019
  17. Junio C HamanoJul 29, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.