git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 0/5] system header cleanup

From
Jeff King <peff@peff.net>
Date
Jul 28, 2019, 22:19 UTC
Message-ID
<20190728221904.GA21379@sigill.intra.peff.net>
In-Reply-To
<20190728200724.35630-1-carenas@gmail.com>
On Sun, Jul 28, 2019 at 01:07:19PM -0700, Carlo Marcelo Arenas Belón wrote:
Show 11 quoted lines
> This series is a reroll of jk/no-system-includes-in-dot-c with
> cb/xdiff-no-system-includes-in-dot-c applied on top with minor
> fixes for the commit message based on feedback from Johannes
> and the example put forward by Peff with his own patches.
> 
> The changes proposed shouldn't affect any systems (except for
> the 3rd one) and that has since shown to also be needed
> in Alpine Linux (because of _XOPEN_SOURCE redefinition).
> 
> The last 2 patches are new to the series and just cleanup
> the dependency list in xdiff.
Thanks, these all look good to me.
-Peff
Previous: Carlo Marcelo Arenas BelónNext: Junio C Hamano
Message 16 of 17 in “xdiff: avoid accidental redefinition of LFS feature in OpenIndiana”
  1. xdiff: avoid accidental redefinition of LFS feature in OpenIndianaCarlo Marcelo Arenas Belón, Jun 18, 2019
  2. Johannes SchindelinJun 18, 2019
  3. 0/2 a few more redundant system include cleanupsJeff King, Jun 18, 2019
  4. 1/2 verify-tag: drop signal.h includeJeff King, Jun 18, 2019
  5. 2/2 wt-status.h: drop stdio.h includeJeff King, Jun 18, 2019
  6. Carlo ArenasJun 19, 2019
  7. Jeff KingJun 19, 2019
  8. Junio C HamanoJul 3, 2019
  9. Carlo ArenasJul 4, 2019
  10. 0/5 system header cleanupCarlo Marcelo Arenas Belón, Jul 28, 2019
  11. 1/5 verify-tag: drop signal.h includeCarlo Marcelo Arenas Belón, Jul 28, 2019
  12. 2/5 wt-status.h: drop stdio.h includeCarlo Marcelo Arenas Belón, Jul 28, 2019
  13. 3/5 xdiff: drop system includes in xutils.cCarlo Marcelo Arenas Belón, Jul 28, 2019
  14. 5/5 xdiff: remove duplicate headers from xpatience.cCarlo Marcelo Arenas Belón, Jul 28, 2019
  15. 4/5 xdiff: remove duplicate headers from xhistogram.cCarlo Marcelo Arenas Belón, Jul 28, 2019
  16. Jeff KingJul 28, 2019
  17. Junio C HamanoJul 29, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.