[PATCH v2 2/5] wt-status.h: drop stdio.h include
- From
Carlo Marcelo Arenas Belón <carenas@gmail.com>
- Date
- Jul 28, 2019, 20:07 UTC
- Message-ID
- <20190728200724.35630-3-carenas@gmail.com>
- In-Reply-To
- <20190728200724.35630-1-carenas@gmail.com>
From: Jeff King <peff@peff.net>
We started including stdio.h to pick up the declaration of "FILE" in f26a001226 (Enable wt-status output to a given FILE pointer., 2007-09-17). But there's no need, since headers can assume that git-compat-util.h has been included, which covers stdio.
This should just be redundant, and not hurting anything (like pulling in includes out of order) because C files are supposed to always include git-compat-util.h first. But it's worth cleaning up to model good behavior.
Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com> --- wt-status.h | 1 - 1 file changed, 1 deletion(-)
diff --git a/wt-status.h b/wt-status.h index 64f1ddc9fd..8849768e92 100644 --- a/wt-status.h +++ b/wt-status.h @@ -1,7 +1,6 @@ #ifndef STATUS_H #define STATUS_H -#include <stdio.h> #include "string-list.h" #include "color.h" #include "pathspec.h"
-- 2.22.0