Re: [Outreachy PATCH v4 0/2] do not use strbuf_split*()

From: Christian Couder <christian.couder@gmail.com>
Date: Oct 21, 2025, 07:19 UTC
Message-ID: <CAP8UFD3sxU=r-zVmM7xL84qEsDL6cFUceAV4np6uLxFTVOnWXQ@mail.gmail.com>
In-Reply-To: <cover.1760997183.git.belkid98@gmail.com>

On Tue, Oct 21, 2025 at 12:56 AM Olamide Caleb Bello <belkid98@gmail.com> wrote:

Show 8 quoted lines

>
> The patch series by Junio Hamano with link below,
> https://public-inbox.org/git/20250731225433.4028872-1-gitster@poddbox.com/,
> notices that the array of strbufs that calls to strbuf_split*() provides
> are merely used to store the strings gotten from the split and no edit are
> done on these resulting strings making the strbuf_split*() unideal
> for this usecase, with the string_list_split*() being a more suitable
> option in those cases.

Now that the string_list_split*() functions are not used in your series anymore, I think you can remove "with the string_list_split*() being a more suitable option in those cases".

Show 5 quoted lines

> Commit 2efe707054 (wt-status: avoid strbuf_split*(), 2025-07-31) for example,
> in the series, notes that abbrev_oid_in_line() takes one line of rebase
> todo list and splits tokens out of this line using strbuf_split_max().
> However, no simultanous edits that take advantage of the strbuf API take
> place but the tokens are merely used as pieces of strings.

I am not sure taking this commit as an example is really useful now that the string_list_split*() functions are not used in your series anymore. Maybe you can find a more relevant example commit in Junio's series?

[...]

> Olamide Caleb Bello (2):
>   gpg-interface: do not use misdesigned strbuf_split*()
>   gpg-interface: do not use misdesigned strbuf_split*() [Part 2]

I don't think having "[Part 2]" is a good idea if there is no "[Part 1]". And maybe using "part 1/2" and "part 2/2" is even better if you want to go this way (so that would be for example "gpg-interface: do not use misdesigned strbuf_split*(), part 1/2"). Otherwise, I think it's Ok if both commits have exactly the same subject.

Also please start to use the `--in-reply-to=<...>` option of `git send-email` so that your patch series are all in the same thread on the mailing list archive. For example right now if you look at https://lore.kernel.org/git/cover.1760997183.git.belkid98@gmail.com/#r, you will see:

Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top 2025-10-20 22:55 Olamide Caleb Bello [this message] 2025-10-20 22:55 ` [Outreachy PATCH v4 1/2] gpg-interface: do not use misdesigned strbuf_split*() Olamide Caleb Bello 2025-10-21 6:46 ` Christian Couder 2025-10-21 6:51 ` Christian Couder 2025-10-20 22:55 ` [Outreachy PATCH v4 2/2] gpg-interface: do not use misdesigned strbuf_split*() [Part 2] Olamide Caleb Bello

So we don't see the previous patches and messages related to v1, v2 and v3.

If the tutorials and documentation are not clear enough, and you can't make it work, then please ask for help and say what you tried so that we can help you with this.

Thanks.