Re: [Outreachy PATCH v4 2/2] gpg-interface: do not use misdesigned strbuf_split*() [Part 2]

From: Christian Couder <christian.couder@gmail.com>
Date: Oct 21, 2025, 07:01 UTC
Message-ID: <CAP8UFD1-H5jRyd6b5FhgCMLObnErXVr8p0s+kMd0qO5jWkkt2Q@mail.gmail.com>
In-Reply-To: <a830de15ecdb5e5f45625927cb69b2be552bda42.1760997183.git.belkid98@gmail.com>

On Tue, Oct 21, 2025 at 12:57 AM Olamide Caleb Bello <belkid98@gmail.com> wrote:

[...]

> Reported-by: Junio Hamano <gitster@pobox.com>
> Helped-by: Christian Couder <christian.couder@gmail.com>
> Helped-by: Junio Hamano <gitster@pobox.com>
> Helped-by: Krisoffer Haughsbakk

I won't repeat the issues that are the same as in patch 1/2, but please correct them.

[...]

Show 9 quoted lines

> @@ -887,19 +887,21 @@ static char *get_default_ssh_signing_key(void)
>                            &key_stderr, 0);
>
>         if (!ret) {
> -               keys = strbuf_split_max(&key_stdout, '\n', 2);
> -               if (keys[0] && is_literal_ssh_key(keys[0]->buf, &literal_key)) {
> +               begin = key_stdout.buf;
> +               new_line = strchr(begin, '\n');
> +               first_line = xmemdupz(begin, new_line - begin);

What if no \n character is found by strchr()?

Thanks.