Re: [Outreachy PATCH v6 0/2] do not use misdesigned strbuf_split*()

From: Christian Couder <christian.couder@gmail.com>
Date: Oct 24, 2025, 13:25 UTC
Message-ID: <CAP8UFD1fousSKKduFAaZrsV9REnOaRDOQYcqB+rTQ0Ys60OWGA@mail.gmail.com>
In-Reply-To: <xmqqecqtwpl5.fsf@gitster.g>

On Thu, Oct 23, 2025 at 6:27 PM Junio C Hamano <gitster@pobox.com> wrote:

Show 11 quoted lines

>
> Olamide Caleb Bello <belkid98@gmail.com> writes:
>
> > Changes in v6
> > =============
> > - Modify commit messages to have proper structure
> > - Changed logic in get_default_ssh_signing_key() to use xmemdupz() if
> >   key has '\n' and xstrdup() if not.
>
> This round looks good to me.  Christian, should we declare victory
> and mark it for 'next' now?

Yeah, v6 looks good to me too. Acked.

Thanks.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.