git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [GSoC][RFC v2] Improve consistency of sequencer commands

From
Christian Couder <christian.couder@gmail.com>
Date
Mar 30, 2019, 07:16 UTC
Message-ID
<CAP8UFD3b8wxj=T+HpeFAQNGLghs8fpEvQusP7Wq-BRZb3c50dg@mail.gmail.com>
In-Reply-To
<20190329223228.4924-1-rohit.ashiwal265@gmail.com>
Hi Rohit,

On Fri, Mar 29, 2019 at 11:33 PM Rohit Ashiwal <rohit.ashiwal265@gmail.com> wrote:

Show 8 quoted lines
>
> This is the v2 of the draft proposal[1]. I've added some details to the proposal,
> it talks more about what to implement instead of how. It is still incomplete.
>
> I'm currently adding more to the overview section, where I'll document the work
> done by Dscho and Alban. After that I'll find files that will be changed while
> implementing rest of the flags, finally add the basic control and/or data flow
> of the 'how' part.
The plan to improve it looks good to me.
Show 5 quoted lines
> ### List of Contributions at Git:
>
> Repo                              |        Status           |                   Title
> -|-|-
> [git/git][8]                      | Merged in 'next' branch | [Micro][3]**:** Use helper functions in test script

It would be nice to have a link to the last "What's cooking in git.git" email from Junio so we can easily see the current status of your patch/patch series.

Show 22 quoted lines
> [git-for-windows/git][9]          | Merged and released     | [#2077][4]**:** [FIX] git-archive error, gzip -cn : command not found.
> [git-for-windows/build-extra][10] | Merged                  | [#235][5]**:** installer: Fix version of installer and installed file.
>
>
> ## The Project
>
> ### _Improve consistency of sequencer commands_
>
> #### Overview
>
> Stephan Beyer \<s-beyer@gmx.net> tried to introduce git-sequencer as his GSoC
> 2008 [project][6] which executed a sequence of git instructions to  \<HEAD> or
> \<branch> and the sequence was given by a \<file> or through `stdin`. The
> git-sequencer wants to become the common backend for git-am, git-rebase and
> other git commands. Unfortunately, most of the code did not get merged during
> the SoC period but he continued his contributions to the project along with
> Christian Couder \<chriscool@tuxfamily.org> and then mentor Daniel Barkalow
> \<barkalow@iabervon.org>.
>
> The project was continued by Ramkumar Ramachandra \<artagnon@gmail.com> in
> [2011][7], converting it to a builtin and extending its domain to
> git-cherry-pick.

I don't think the sequencer has been converted into a builtin. I am not sure why Ram wrote that he would do that in his proposal as I don't think it was really a goal we had.

By the way, you might want to read the sequencer related article in https://git.github.io/rev_news/2016/10/19/edition-20/ for things that Dscho did.

Show 7 quoted lines
> The learnings from all those works will serve as a huge headstart this year for
> me.
>
> As of now, there are still some inconsistencies among these commands, e.g.,
> there is no `--skip` flag in `git-cherry-pick` while one exists for
> `git-rebase`. This project aims to remove inconsistencies in how the command
> line options are handled.
[...]
> 5. `[Bonus]` As familiarity with the code increases, I might be able to implement
> the feature of rewriting commits in time.

I had to go back to the "Points to work on" section to understand what this was about. Please describe what this is about in a clearer way.

Show 5 quoted lines
> 6. `[Bonus]` If everything goes well and time permits, discuss with the mentor(s)
> the possibility of deprecating the am backend of rebase. This point is last to
> work on as it provides no "cosmetic" difference on the user side. Elijah
> [mentioned][12] the possibility of a "social" problem that might occur which shall
> be discussed then.

Maybe it would be interesting to see if there is a performance difference between the 2 backends.

[...]
Show 11 quoted lines
> #### Relevant Work
>
> Dscho and I had a talk on how a non-am backend should implement `git rebase
> --whitespace=fix`, which he warned may become a large project (as it turns out
> it is a sub-task in one of the [proposed ideas][11]), we were trying to
> integrate this on git-for-windows first.
>
> Keeping warning in mind, I discussed this project with Rafael and he suggested
> (with a little bit uncertainty in mind) that I should work on implementing a
> git-diff flag that generates a patch that when applied, will remove whitespace
> errors which I am currently working on.
Nice!
Previous: Elijah NewrenNext: Elijah Newren
Message 18 of 23 in “[GSoC] Introduction”
  1. Rohit AshiwalFeb 24, 2019
  2. Johannes SchindelinFeb 24, 2019
  3. Christian CouderFeb 25, 2019
  4. Rohit AshiwalFeb 25, 2019
  5. Christian CouderFeb 25, 2019
  6. Eric SunshineFeb 25, 2019
  7. [GSoC][RFC] Proposal: Improve consistency of sequencer commandsRohit Ashiwal, Mar 22, 2019
  8. Christian CouderMar 23, 2019
  9. Rohit AshiwalMar 24, 2019
  10. Elijah NewrenMar 24, 2019
  11. Rohit AshiwalMar 24, 2019
  12. [GSoC][RFC v2] Improve consistency of sequencer commandsRohit Ashiwal, Mar 29, 2019
  13. Elijah NewrenMar 29, 2019
  14. Rohit AshiwalMar 29, 2019
  15. Elijah NewrenMar 30, 2019
  16. Rohit AshiwalMar 30, 2019
  17. Elijah NewrenMar 30, 2019
  18. Christian CouderMar 30, 2019
  19. Elijah NewrenMar 30, 2019
  20. [GSoC][RFC v3] Proposal: Improve consistency of sequencer commandsRohit Ashiwal, Apr 5, 2019
  21. Christian CouderApr 7, 2019
  22. Rohit AshiwalApr 7, 2019
  23. Christian CouderApr 7, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.