Re: [GSoC][RFC v2] Improve consistency of sequencer commands

From: Elijah Newren <newren@gmail.com>
Date: Mar 30, 2019, 17:13 UTC
Message-ID: <CABPp-BFdg8M17YuhKOrtTS3Xeyf2TQB1+vBzDVTo5EzMebyLEA@mail.gmail.com>
In-Reply-To: <20190330084822.11285-1-rohit.ashiwal265@gmail.com>

On Sat, Mar 30, 2019 at 1:49 AM Rohit Ashiwal <rohit.ashiwal265@gmail.com> wrote:

Show 16 quoted lines

>
> Hi Elijah
>
> On 2019-03-30  0:38 UTC Elijah Newren <newren@gmail.com> wrote:
>
> > I'm curious if you're looking at an old version of the documentation
> > (...or maybe the documentation just isn't that clear?).  Interactive
> > rebases have supported --signoff since commit a852ec7f273c ("rebase:
> > extend --signoff support", 2018-03-20)
>
> Oh~ after having a quick look at my currently installed version of git,
> it was 2.17.1, which has outdated man pages :sweat_smile:. Yes, you are
> correct, I'm sorry.
>
> Feeling dumb
> Rohit

Don't feel dumb. I like the initiative. Also, since you highlighted it, there might be an issue with picking merge commits; either they aren't affected by --signoff and should be, or the documentation should be updated to mention they are handled too. So there is actually something here, I think.