Re: [GSoC][RFC v2] Improve consistency of sequencer commands

From: Rohit Ashiwal <rohit.ashiwal265@gmail.com>
Date: Mar 29, 2019, 23:34 UTC
Message-ID: <20190329233407.13049-1-rohit.ashiwal265@gmail.com>
In-Reply-To: <CABPp-BETuwt96jeBMMhzT84-=-MqEA3D7uhLb2uxW3fijx7p7Q@mail.gmail.com>

Hi Elijah

On Sat, Mar 30, 2019 at 4:56 AM Elijah Newren <newren@gmail.com> wrote:

>
> Overall this looks pretty good to me, just one question...
>

:)

> >     5. `[Bonus]` --signoff
>
> --signoff is new and surprises me.  What's the plan with that one?
>

I was reading the documentation of git-rebase[1], where I found that `--signoff` flag is not available for interactive backend, i.e., it is not possible to convert a commit into `Signed-off-by` commit while interactive rebasing.

I though it might be a nice bonus to add, hence I listed it in "the plan".

Thanks Rohit

[1]: https://git-scm.com/docs/git-rebase#Documentation/git-rebase.txt---signoff