Re: [GSoC][PATCH 5/6] submodule: port submodule subcommand sync from shell to C

From: Christian Couder <christian.couder@gmail.com>
Date: Jun 22, 2017, 06:50 UTC
Message-ID: <CAP8UFD3_toXcKzMmikkwaiGi7oHJ0BcT4s1fYe6hW4mYjUdmGA@mail.gmail.com>
In-Reply-To: <20170619215025.10086-5-pc44800@gmail.com>

On Mon, Jun 19, 2017 at 11:50 PM, Prathamesh Chavan <pc44800@gmail.com> wrote:

Show 14 quoted lines

> +static char *get_up_path(const char *path)
> +{
> +       int i = count_slashes(path);
> +       struct strbuf sb = STRBUF_INIT;
> +
> +       while (i--)
> +               strbuf_addstr(&sb, "../");
> +
> +       /*
> +        *Check if 'path' ends with slash or not
> +        *for having the same output for dir/sub_dir
> +        *and dir/sub_dir/
> +        */
> +       if (!is_dir_sep(path[i - 1]))

i is always 0 here, as we decrease it until it gets to 0 above.

> +               strbuf_addstr(&sb, "../");
> +
> +       return strbuf_detach(&sb, NULL);
> +}