Re: [GSoC][PATCH 1/6] dir: create function count_slashes

From: Stefan Beller <sbeller@google.com>
Date: Jun 20, 2017, 17:20 UTC
Message-ID: <CAGZ79kb7XTbJ5wHhRwXKURDU3xj_3mHFFmjxS1G_T2X_BoG=dQ@mail.gmail.com>
In-Reply-To: <20170619215025.10086-1-pc44800@gmail.com>

On Mon, Jun 19, 2017 at 2:50 PM, Prathamesh Chavan <pc44800@gmail.com> wrote:

Show 17 quoted lines

> Similar functions exist in apply.c and builtin/show-branch.c for
> counting the number of slashes in a string. Also in the later
> patches, we introduce a third caller for the same. Hence, we unify
> it now by cleaning the existing functions and declaring a common
> function count_slashes in dir.h and implementing it in dir.c to
> remove this code duplication.
>
> Mentored-by: Christian Couder <christian.couder@gmail.com>
> Mentored-by: Stefan Beller <sbeller@google.com>
> Signed-off-by: Junio C Hamano <gitster@pobox.com>
> Signed-off-by: Prathamesh Chavan <pc44800@gmail.com>
> Signed-off-by: Junio C Hamano <gitster@pobox.com>
> ---
> The complete build report of this is available at:
> https://travis-ci.org/pratham-pc/git/builds/
> Branch: All-patch-series
> Build #111

This patch was sent separately a couple days ago, see the latest "What's cooking in git.git" (Jun 2017, #05; Mon, 19) https://public-inbox.org/git/xmqqh8zbspm7.fsf@gitster.mtv.corp.google.com/

  * pc/dir-count-slashes (2017-06-12) 1 commit
    (merged to 'next' on 2017-06-19 at 57351a2771)
   + dir: create function count_slashes()

   Three instances of the same helper function have been consolidated
   to one.

   Will merge to 'master'.

so if you pull Junios git and rebase on top of his master branch this should be already included there. (In that case there is no need for you to carry this patch. It is just cumbersome for you and might confuse Junio, which patches exactly to apply)

Thanks, Stefan