Re: [PATCH V2] config: add --expiry-date

From: Christian Couder <christian.couder@gmail.com>
Date: Nov 14, 2017, 06:21 UTC
Message-ID: <CAP8UFD3TbmZ3bRwg-fRoSJWAFaa=UDxVsZphn_3Nt4wMz1N2=A@mail.gmail.com>
In-Reply-To: <1510625073-8842-1-git-send-email-hsed@unimetic.com>

On Tue, Nov 14, 2017 at 3:04 AM,  <hsed@unimetic.com> wrote:

Show 17 quoted lines

> From: Haaris <hsed@unimetic.com>
>
> Description:
> This patch adds a new option to the config command.
>
> Uses flag --expiry-date as a data-type to covert date-strings to
> timestamps when reading from config files (GET).
> This flag is ignored on write (SET) because the date-string is stored in
> config without performing any normalization.
>
> Creates a few test cases and documentation since its a new feature.
>
> Motivation:
> A parse_expiry_date() function already existed for api calls,
> this patch simply allows the function to be used from the command line.
>
> Signed-off-by: Haaris <hsed@unimetic.com>

Documentation/SubmittingPatches contains the following:

"Also notice that a real name is used in the Signed-off-by: line. Please don't hide your real name."

And there is the following example before that:

        Signed-off-by: Random J Developer <random@developer.example.org>

So it looks like "a real name" actually means "a real firstname and a real surname".

It would be nice if your "Signed-off-by:" could match this format.

Also if you have a "From:" line at the beginning of the patch, please make sure that the name there is tha same as on the "Signed-off-by:".

Thanks for working on this, Christian.