Re: [PATCH] config: added --expiry-date type support
- From
Jeff King <peff@peff.net>
- Date
- Nov 12, 2017, 14:22 UTC
- Message-ID
- <20171112142204.2nuhh726imqksdug@sigill.intra.peff.net>
- In-Reply-To
- <20171112135553.GA10563@alpha.vpn.ikke.info>
On Sun, Nov 12, 2017 at 02:55:53PM +0100, Kevin Daudt wrote:
> What I'm also missing is a motivation on why you added this option, > which should be part of your commit message. As far as I know, there is > currently no config setting that expects a date format.
This patch came from submitGit, and there's a bit more at:
https://github.com/git/git/pull/433
(though obviously that informatoin should go into the commit message).
We do parse expiration dates from config in a few places, like gc.reflogexpire, etc. There's no way for a script using git-config to do the same (either adding an option specific to the script, or trying to do some analysis on gc.reflogexpire).
-Peff