Re: [PATCH V4] config: add --expiry-date

From: Jeff King <peff@peff.net>
Date: Nov 20, 2017, 20:37 UTC
Message-ID: <20171120203702.mdd3hkwezxyf7vtg@sigill.intra.peff.net>
In-Reply-To: <CAGZ79ka+5o07cz4A8=Gu_VqO1hYqqO=8Ju1uAaDY23s7xjCWvw@mail.gmail.com>

On Mon, Nov 20, 2017 at 12:28:11PM -0800, Stefan Beller wrote:

Show 6 quoted lines

> > +cc Stefan, who added the die(). It may be that we don't care that much
> > these days about recovering from broken .gitmodules files.
> 
> By that you mean commits like 37f52e9344 (submodule-config:
> keep shallow recommendation around, 2016-05-26) for example?
> That adds a git_config_bool to the submodule config machinery.

I actually meant ea2fa5a338 (submodule-config: keep update strategy around, 2016-02-29), which adds an actual die() into parse_config(). But yeah, I think the end result is the same.

> I agree that we'd want to be more careful, but for now I'd put it to the
> #leftoverbits.

Fine by me. While I think the original intent was to be more lenient to malformed .gitmodules, it's not like we're seeing bug reports about it.

-Peff