git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [GSoC] [PATCH v2] t1011: replace test -f with test_path_is_file

From
Christian Couder <christian.couder@gmail.com>
Date
Apr 14, 2022, 08:19 UTC
Message-ID
<CAP8UFD3RtQecxOQWVeapH1CYsMiY2+MoHeugb9bvOsFVnozy=w@mail.gmail.com>
In-Reply-To
<20220412203722.10484-1-siddharthasthana31@gmail.com>

On Wed, Apr 13, 2022 at 2:06 AM Siddharth Asthana <siddharthasthana31@gmail.com> wrote:

>
> Use test_path_is_file() instead of 'test -f' for better debugging
> information.

Actually it looks like you are also using test_path_is_missing() now, so you might want to update the commit message, and maybe also the commit subject.

In the commit message it might be nice if there were some explanations about why `test_path_is_missing PATH` should be used instead of `! test_path_is_file PATH` or `test ! -f PATH` or `! test -f PATH`.

The diff part of the patch looks good to me. Thanks!
Previous: Siddharth AsthanaNext: Junio C Hamano
Message 5 of 8 in “t1011: replace test -f with test_path_is_file”
  1. Siddharth AsthanaApr 9, 2022
  2. Junio C HamanoApr 11, 2022
  3. Siddharth AsthanaApr 12, 2022
  4. [GSoC] [PATCH v2] t1011: replace test -f with test_path_is_fileSiddharth Asthana, Apr 12, 2022
  5. Christian CouderApr 14, 2022
  6. Junio C HamanoApr 14, 2022
  7. Siddharth AsthanaApr 16, 2022
  8. t1011: replace test -f with test_path_is* helpersSiddharth Asthana, Apr 16, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.