From: Christian Couder <christian.couder@gmail.com>
Date: Thu, 14 Apr 2022 08:19:07 GMT
Subject: Re: [GSoC] [PATCH v2] t1011: replace test -f with test_path_is_file
Message-ID: <CAP8UFD3RtQecxOQWVeapH1CYsMiY2+MoHeugb9bvOsFVnozy=w@mail.gmail.com>
In-Reply-To: <20220412203722.10484-1-siddharthasthana31@gmail.com>

On Wed, Apr 13, 2022 at 2:06 AM Siddharth Asthana
<siddharthasthana31@gmail.com> wrote:
>
> Use test_path_is_file() instead of 'test -f' for better debugging
> information.

Actually it looks like you are also using test_path_is_missing() now,
so you might want to update the commit message, and maybe also the
commit subject.

In the commit message it might be nice if there were some explanations
about why `test_path_is_missing PATH` should be used instead of `!
test_path_is_file PATH` or `test ! -f PATH` or `! test -f PATH`.

The diff part of the patch looks good to me. Thanks!